Remove templateId and simplify EmailProof validation in ZKEmailUtils
#210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestognw
changed the title
ernestognw
changed the title
ernestognw
changed the title
ernestognw
changed the title
templateId and simplify EmailProof validation in ZKEmailUtils
ernestognw
requested review from
zkfriendly,
benceharomi and
a team
as code owners
Open
zkfriendly
approved these changes
Aug 12, 2025
| * NOTE: The returned `emailProof` object should not be accessed if `success` is false. Trying to access the data may | ||
| * cause revert/panic. | ||
| */ | ||
| function tryDecodeEmailProof( |
There was a problem hiding this comment.
Curious to know what the main benefit of these checks is? Looking at the places where this is used, there is always a call to isValidZKEmail, which will reject a malformed EmailProof either by failing to pass the zk-proof checks (including DKIM checks and command matching) or by reverting somewhere. However, it does help to revert early if EmailProof is not a valid struct. So basically would these be redundant checks for valid EmailProofs? or is there some other attack vector if these checks are not in place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines the ZKEmailUtils by receiving an EmailProof directly instead of an EmailAuthMsg struct. From the original struct, the
templateIdwas unused and not included in the proof so anyone can construct the expected value, so it was removed.On the
SignerZKEmailandERC7913ZKEmailVerifierside, their implementation was simplified following changes in ZKEmailUtils.Key Changes:
templateIdandskippedCommandPrefixfunctionality across all ZKEmail contractstryDecodeEmailProoffunction for safe calldata decoding with comprehensive bounds checkingEmailProoffield encodingThe simplified implementation reduces complexity while preserving all essential security guarantees.